fix(eslint-plugin): [no-shadow] handle false positives on generics and parameters by yeonjuan · Pull Request #5902 · typescript-eslint/typescript-eslint

yeonjuan · 2022-10-29T15:35:24Z

PR Checklist

Addresses an existing open issue: fixes Bug: [typescript-eslint/no-shadow] Rest (...args) parameter name in generic declaration shadows actual parameter name #5853
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

…d parameters

typescript-eslint · 2022-10-29T15:35:26Z

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

nx-cloud · 2022-10-29T15:35:26Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3652ffc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

netlify · 2022-10-29T15:35:29Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`3652ffc`
🔍 Latest deploy log	https://app.netlify.com/sites/typescript-eslint/deploys/63717d405ced6000081028c4
😎 Deploy Preview	https://deploy-preview-5902--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

codecov · 2022-10-29T15:52:52Z

Codecov Report

Merging #5902 (e4fa515) into main (91d71bc) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head e4fa515 differs from pull request most recent head 3652ffc. Consider uploading reports for the commit 3652ffc to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5902      +/-   ##
==========================================
- Coverage   91.39%   91.37%   -0.03%     
==========================================
  Files         365      365              
  Lines       12327    12193     -134     
  Branches     3606     3558      -48     
==========================================
- Hits        11266    11141     -125     
+ Misses        755      747       -8     
+ Partials      306      305       -1

Flag	Coverage Δ
unittest	`91.37% <100.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/eslint-plugin/src/rules/no-shadow.ts	`77.52% <100.00%> (+1.68%)`	⬆️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts	`93.85% <0.00%> (-4.77%)`	⬇️
...gin/src/rules/naming-convention-utils/validator.ts	`95.54% <0.00%> (-1.28%)`	⬇️
...lugin-internal/src/rules/plugin-test-formatting.ts	`79.85% <0.00%> (-1.08%)`	⬇️
...kages/eslint-plugin/src/rules/naming-convention.ts	`81.09% <0.00%> (-0.77%)`	⬇️
...ackages/eslint-plugin/src/rules/no-extra-parens.ts	`90.78% <0.00%> (-0.68%)`	⬇️
...eslint-plugin/src/rules/consistent-type-imports.ts	`94.26% <0.00%> (-0.29%)`	⬇️
packages/utils/src/ts-eslint/RuleTester.ts	`100.00% <0.00%> (ø)`
.../eslint-plugin/src/rules/sort-type-constituents.ts	`90.74% <0.00%> (ø)`
...-plugin/src/rules/naming-convention-utils/enums.ts	`100.00% <0.00%> (ø)`
... and 4 more

JoshuaKGoldberg

💯, thanks for fixing this @yeonjuan! 🚀

andsens · 2022-11-14T08:05:43Z

Awesome stuff @yeonjuan! Thank you very much :-)

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.42.1/5.43.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.42.1` -> `5.43.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.42.1/5.43.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14) [Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0) ##### Bug Fixes - **eslint-plugin:** \[no-shadow] handle false positives on generics and parameters ([#5902](typescript-eslint/typescript-eslint#5902)) ([769e8c8](typescript-eslint/typescript-eslint@769e8c8)) - **eslint-plugin:** \[promise-function-async] handle keyword token ([#5907](typescript-eslint/typescript-eslint#5907)) ([f25a94f](typescript-eslint/typescript-eslint@f25a94f)) ##### Features - **eslint-plugin:** \[consistent-type-imports] support fixing to inline types ([#5050](typescript-eslint/typescript-eslint#5050)) ([75dcdf1](typescript-eslint/typescript-eslint@75dcdf1)) - **eslint-plugin:** \[naming-convention] add support for "override" and "async" modifiers ([#5310](typescript-eslint/typescript-eslint#5310)) ([#5610](typescript-eslint/typescript-eslint#5610)) ([c759da1](typescript-eslint/typescript-eslint@c759da1)) - **eslint-plugin:** \[prefer-optional-chain] support suggesting `!foo || !foo.bar` as a valid match for the rule ([#5594](typescript-eslint/typescript-eslint#5594)) ([923d486](typescript-eslint/typescript-eslint@923d486)) #### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07) ##### Bug Fixes - **eslint-plugin:** isTypeReadonly stack overflow ([#5875](typescript-eslint/typescript-eslint#5875)) ([#5876](typescript-eslint/typescript-eslint#5876)) ([2d9a33c](typescript-eslint/typescript-eslint@2d9a33c)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.43.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5430-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5421v5430-2022-11-14) [Compare Source](typescript-eslint/typescript-eslint@v5.42.1...v5.43.0) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) #### [5.42.1](typescript-eslint/typescript-eslint@v5.42.0...v5.42.1) (2022-11-07) **Note:** Version bump only for package [@typescript-eslint/parser](https://github.com/typescript-eslint/parser) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1639 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

fix(eslint-plugin): [no-shadow] handle false positives on generics an…

e4fa515

…d parameters

bradzacher added the bug Something isn't working label Oct 31, 2022

yeonjuan marked this pull request as ready for review October 31, 2022 03:02

JoshuaKGoldberg previously approved these changes Nov 13, 2022

View reviewed changes

Comment thread packages/eslint-plugin/src/rules/no-shadow.ts

JoshuaKGoldberg dismissed their stale review via e500853 November 13, 2022 23:26

JoshuaKGoldberg added 2 commits November 13, 2022 18:26

Update packages/eslint-plugin/src/rules/no-shadow.ts

e500853

Merge branch 'main' into fix/typescript-eslint#5853

3652ffc

JoshuaKGoldberg enabled auto-merge (squash) November 13, 2022 23:26

JoshuaKGoldberg approved these changes Nov 13, 2022

View reviewed changes

JoshuaKGoldberg merged commit 769e8c8 into typescript-eslint:main Nov 13, 2022

github-actions Bot locked as resolved and limited conversation to collaborators Nov 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(eslint-plugin): [no-shadow] handle false positives on generics and parameters#5902

fix(eslint-plugin): [no-shadow] handle false positives on generics and parameters#5902
JoshuaKGoldberg merged 3 commits intotypescript-eslint:mainfrom
yeonjuan:fix/#5853

yeonjuan commented Oct 29, 2022

Uh oh!

typescript-eslint Bot commented Oct 29, 2022

Uh oh!

nx-cloud Bot commented Oct 29, 2022 •

edited

Loading

Uh oh!

netlify Bot commented Oct 29, 2022 •

edited

Loading

Uh oh!

codecov Bot commented Oct 29, 2022 •

edited

Loading

Uh oh!

JoshuaKGoldberg left a comment

Uh oh!

Uh oh!

andsens commented Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

yeonjuan commented Oct 29, 2022

PR Checklist

Overview

Uh oh!

typescript-eslint Bot commented Oct 29, 2022

Uh oh!

nx-cloud Bot commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

netlify Bot commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

codecov Bot commented Oct 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andsens commented Nov 14, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nx-cloud Bot commented Oct 29, 2022 •

edited

Loading

netlify Bot commented Oct 29, 2022 •

edited

Loading

codecov Bot commented Oct 29, 2022 •

edited

Loading