Skip to content

fix(scope-manager): visit static blocks#5489

Merged
bradzacher merged 1 commit intotypescript-eslint:mainfrom
DMartens:scope-manager-static-block
Aug 17, 2022
Merged

fix(scope-manager): visit static blocks#5489
bradzacher merged 1 commit intotypescript-eslint:mainfrom
DMartens:scope-manager-static-block

Conversation

@DMartens
Copy link
Copy Markdown
Contributor

@DMartens DMartens commented Aug 16, 2022

PR Checklist

Overview

Only added the visitor for static blocks for classes as the scope was already present.

@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Aug 16, 2022 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6c98e88. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Copy Markdown
Contributor

typescript-eslint Bot commented Aug 16, 2022

Thanks for the PR, @DMartens!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 6c98e88
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62fb76a0bb98070009593081
😎 Deploy Preview https://deploy-preview-5489--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #5489 (6c98e88) into main (830b946) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5489      +/-   ##
==========================================
- Coverage   91.74%   91.61%   -0.13%     
==========================================
  Files         366      347      -19     
  Lines       12344    10929    -1415     
  Branches     3601     3220     -381     
==========================================
- Hits        11325    10013    -1312     
+ Misses        668      592      -76     
+ Partials      351      324      -27
Flag Coverage Δ
unittest 91.61% <100.00%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/scope-manager/src/scope/ClassStaticBlockScope.ts 100.00% <ø> (+25.00%) ⬆️
...kages/scope-manager/src/referencer/ClassVisitor.ts 94.11% <100.00%> (+0.10%) ⬆️
packages/typescript-estree/src/ts-estree/index.ts
...ges/typescript-estree/src/create-program/shared.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/simple-traverse.ts
...ript-estree/src/create-program/createSourceFile.ts
...-estree/src/create-program/createProjectProgram.ts
packages/typescript-estree/src/convert-comments.ts
packages/visitor-keys/src/get-keys.ts
... and 13 more

JoshuaKGoldberg
JoshuaKGoldberg approved these changes Aug 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm still pretty new to this area so we should let another maintainer approve. But this seems pretty straightforward 😄

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Aug 16, 2022
bradzacher
bradzacher approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops - looks like this was supposed to be actioned in #4211 but the visitor wasn't added.

thanks for thsi!

@bradzacher bradzacher changed the title feat(scope-manager): visit static blocks fix(scope-manager): visit static blocks Aug 17, 2022
@bradzacher bradzacher added the bug Something isn't working label Aug 17, 2022
@bradzacher bradzacher merged commit 78745c2 into typescript-eslint:main Aug 17, 2022
@DMartens DMartens deleted the scope-manager-static-block branch August 17, 2022 09:15
@bradzacher bradzacher mentioned this pull request Aug 31, 2022
Merged
3 tasks
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

@bradzacher bradzacher bradzacher approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: [scope-manager] Static Blocks do not introduce a scope

3 participants

@DMartens @JoshuaKGoldberg @bradzacher