fix(visitor-keys): add missing visitor keys#4731
fix(visitor-keys): add missing visitor keys#4731bradzacher merged 2 commits intotypescript-eslint:mainfrom
Conversation
|
Thanks for the PR, @DMartens! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bradzacher
left a comment
There was a problem hiding this comment.
Thanks for this!
Some of these are good to go.
However we should remove the following:
TSModuleDeclaration-modifiersTSEnumDeclaration-modifiersTSInterfaceDeclaration-implements
I've filed #4759 - we should remove these from the AST in the next major.
the others are all valid bugs that are missing!
bradzacher
left a comment
There was a problem hiding this comment.
LGTM - thanks for adding these!
PR Checklist
Overview
This adds the missing visitor keys mentioned in the issue #4724.