feat(parser): add `parserOptions.emitDecoratorMetadata` by xboy2012 · Pull Request #4646 · typescript-eslint/typescript-eslint

xboy2012 · 2022-03-08T07:12:38Z

PR Checklist

Addresses an existing issue: fixes [consistent-type-imports] False positive with decorator metadata #4608
That issue was marked as accepting prs
Steps in CONTRIBUTING.md were taken

Overview

emitDecoratorMetadata is added to ParserOptions as an optional param

The parser first try to use compilerOptions.emitDecoratorMetadata as it did before.

If parserOptions.project is set, then parserOptions.emitDecoratorMetadata is used.

nx-cloud · 2022-03-08T07:12:40Z

☁️ Nx Cloud Report

CI ran the following commands for commit d799cd2. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 41 targets

Sent with 💌 from NxCloud.

typescript-eslint · 2022-03-08T07:12:44Z

Thanks for the PR, @xboy2012!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

netlify · 2022-03-08T07:12:47Z

✔️ Deploy Preview for typescript-eslint ready!

🔨 Explore the source changes: d799cd2

🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/622b59fb84e9730009c34719

😎 Browse the preview: https://deploy-preview-4646--typescript-eslint.netlify.app

bradzacher

thanks for hopping on this so fast!

please make sure this is also documented in the readme:
https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/parser#configuration

codecov · 2022-03-10T02:48:01Z

Codecov Report

Merging #4646 (eebca34) into main (cf325ce) will decrease coverage by 1.59%.
The diff coverage is 100.00%.

❗ Current head eebca34 differs from pull request most recent head d799cd2. Consider uploading reports for the commit d799cd2 to get more accurate results

@@            Coverage Diff             @@
##             main    #4646      +/-   ##
==========================================
- Coverage   94.25%   92.65%   -1.60%     
==========================================
  Files         151      315     +164     
  Lines        7971    11259    +3288     
  Branches     2573     3329     +756     
==========================================
+ Hits         7513    10432    +2919     
- Misses        262      563     +301     
- Partials      196      264      +68

Flag	Coverage Δ
unittest	`92.65% <100.00%> (-1.60%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/typescript-estree/src/convert.ts	`98.37% <100.00%> (ø)`
packages/scope-manager/src/lib/es2022.error.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/variable/index.ts	`50.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2022.array.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/referencer/index.ts	`100.00% <0.00%> (ø)`
...ckages/scope-manager/src/referencer/VisitorBase.ts	`87.87% <0.00%> (ø)`
packages/scope-manager/src/lib/es2017.string.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/es2022.full.ts	`100.00% <0.00%> (ø)`
packages/scope-manager/src/lib/esnext.bigint.ts	`100.00% <0.00%> (ø)`
...src/definition/ImplicitGlobalVariableDefinition.ts	`100.00% <0.00%> (ø)`
... and 155 more

xboy2012 · 2022-03-10T02:57:17Z

ready to merge now. @bradzacher

bradzacher

this is looking good to me - thanks for doing this!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.14.0` -> `5.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.14.0/5.15.0) | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.14.0` -> `5.15.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.14.0/5.15.0) | --- ### Release Notes <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/eslint-plugin)</summary> ### [`v5.15.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#5150-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5140v5150-2022-03-14) [Compare Source](typescript-eslint/typescript-eslint@v5.14.0...v5.15.0) ##### Features - **parser:** add `parserOptions.emitDecoratorMetadata` ([#4646](typescript-eslint/typescript-eslint#4646)) ([e3dd343](typescript-eslint/typescript-eslint@e3dd343)) </details> <details> <summary>typescript-eslint/typescript-eslint (@typescript-eslint/parser)</summary> ### [`v5.15.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#5150-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5140v5150-2022-03-14) [Compare Source](typescript-eslint/typescript-eslint@v5.14.0...v5.15.0) ##### Features - **parser:** add `parserOptions.emitDecoratorMetadata` ([#4646](typescript-eslint/typescript-eslint#4646)) ([e3dd343](typescript-eslint/typescript-eslint@e3dd343)) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1225 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

bradzacher requested changes Mar 8, 2022

View reviewed changes

Comment thread packages/parser/src/parser.ts Outdated

bradzacher added the enhancement New feature or request label Mar 8, 2022

bradzacher changed the title ~~feat: use emitDecoratorMetadata from parserOptions~~ feat(parser): add parserOptions.emitDecoratorMetadata Mar 8, 2022

xboy2012 force-pushed the main branch from 60001ee to 2afa9c8 Compare March 8, 2022 13:47

xboy2012 requested a review from bradzacher March 11, 2022 02:32

feat(parser): add parserOptions.emitDecoratorMetadata

d799cd2

xboy2012 force-pushed the main branch from ce65ba7 to d799cd2 Compare March 11, 2022 14:17

bradzacher approved these changes Mar 11, 2022

View reviewed changes

bradzacher merged commit e3dd343 into typescript-eslint:main Mar 11, 2022

This was linked to issues Mar 11, 2022

[consistent-type-imports] support decorator metaData without specifying project #4638

Closed

[consistent-type-imports] Using with --fix changes constructor imports to type imports in nest and angular #3630

Closed

github-actions Bot locked as resolved and limited conversation to collaborators May 24, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(parser): add `parserOptions.emitDecoratorMetadata`#4646

feat(parser): add `parserOptions.emitDecoratorMetadata`#4646
bradzacher merged 1 commit intotypescript-eslint:mainfrom
xboy2012:main

xboy2012 commented Mar 8, 2022

Uh oh!

nx-cloud Bot commented Mar 8, 2022 •

edited

Loading

Uh oh!

typescript-eslint Bot commented Mar 8, 2022

Uh oh!

netlify Bot commented Mar 8, 2022 •

edited

Loading

Uh oh!

bradzacher left a comment •

edited

Loading

Uh oh!

Uh oh!

codecov Bot commented Mar 10, 2022 •

edited

Loading

Uh oh!

xboy2012 commented Mar 10, 2022

Uh oh!

bradzacher left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

xboy2012 commented Mar 8, 2022

PR Checklist

Overview

Uh oh!

nx-cloud Bot commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

☁️ Nx Cloud Report

Uh oh!

typescript-eslint Bot commented Mar 8, 2022

Uh oh!

netlify Bot commented Mar 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bradzacher left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov Bot commented Mar 10, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xboy2012 commented Mar 10, 2022

Uh oh!

bradzacher left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nx-cloud Bot commented Mar 8, 2022 •

edited

Loading

netlify Bot commented Mar 8, 2022 •

edited

Loading

bradzacher left a comment •

edited

Loading

codecov Bot commented Mar 10, 2022 •

edited

Loading