This repository was archived by the owner on Sep 1, 2024. It is now read-only.
Add a package sideEffects field#350
Merged
ljharb merged 1 commit intofacebook:masterfrom May 25, 2021
Merged
Conversation
ljharb
approved these changes
May 25, 2021
Contributor
ljharb
left a comment
There was a problem hiding this comment.
it's a non-standard field, but since it'll never be a standard one, it won't hurt
Contributor
Author
|
@ljharb can we please publish this change? Been waiting 6 months 😅 |
Contributor
|
v15.8.0 is released. |
This was referenced May 24, 2024
Open
This was referenced Jun 18, 2024
This was referenced Aug 9, 2024
This was referenced Sep 6, 2024
This was referenced Sep 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a package
sideEffectsfield with afalsevalue. This allows tree-shaking and dead-code-elimination to work much better, eliminating imports ofprop-typesif all of the imports end up being unused.This change could significantly improve the bundle size of projects that nest
propTypesunder a conditional so they will be eliminated from a production bundle, for example:https://github.com/jaydenseric/device-agnostic-ui/blob/89e5ba0b8c0ee5a8fb38f4ed74e7f19a6b4970d7/src/public/components/Button.js#L25-L32
Currently, because the
prop-typespackage doesn't have a"sideEffects": falsefield, for a production bundle esbuild eliminates theButton.propTypes = {declaration but it leaves theconst PropTypes = require('prop-types');.