docs: add background to code-path-diagrams for dark-mode by Tanujkanti4441 · Pull Request #16822 · eslint/eslint

Tanujkanti4441 · 2023-01-24T13:43:57Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

have made a new container called 'img-container' to wrap all the image diagrams and added the background and border radius property to that new container.

Is there anything you'd like reviewers to focus on?

related to issue #16683

netlify · 2023-01-24T13:44:03Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`bdf4cf3`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/63d2068309c37900087ad9e4
😎 Deploy Preview	https://deploy-preview-16822--docs-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

amareshsm

Can you pls add before and after screenshots?

Tanujkanti4441 · 2023-01-25T04:03:37Z

https://deploy-preview-16822--docs-eslint.netlify.app/extend/code-path-analysis

before

after

snitin315

I'm 👍🏻 on this change for applying white background in light mode and --color-neutral-300 in dark mode.

@Tanujkanti4441 There is another image in the Architecture doc can you also update that page?

Tanujkanti4441 · 2023-01-26T04:54:44Z

I'm 👍🏻 on this change for applying white background in light mode and --color-neutral-300 in dark mode.

@Tanujkanti4441 There is another image in the Architecture doc can you also update that page?

Done. https://deploy-preview-16822--docs-eslint.netlify.app/contribute/architecture/

amareshsm

LGTM. I'm okay with this change.

harish-sethuraman

LGTM. Will require someone from @eslint/eslint-tsc to confirm if this is fine

snitin315

LGTM, thanks for contributing.

kecrily

LGTM

mdjermanovic

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.32.0` -> `8.33.0`](https://renovatebot.com/diffs/npm/eslint/8.32.0/8.33.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.33.0`](https://github.com/eslint/eslint/releases/tag/v8.33.0) [Compare Source](eslint/eslint@v8.32.0...v8.33.0) #### Features - [`2cc7954`](eslint/eslint@2cc7954) feat: add `restrictDefaultExports` option to no-restricted-exports rule ([#16785](eslint/eslint#16785)) (Nitin Kumar) #### Documentation - [`17f4be2`](eslint/eslint@17f4be2) docs: Fix examples in no-multiple-empty-lines rule ([#16835](eslint/eslint#16835)) (jonz94) - [`9c7cfe3`](eslint/eslint@9c7cfe3) docs: 'Source Code' content in 'Set up Development Environment' page ([#16780](eslint/eslint#16780)) (Ben Perlmutter) - [`ede5c64`](eslint/eslint@ede5c64) docs: Custom processors page ([#16802](eslint/eslint#16802)) (Ben Perlmutter) - [`2620614`](eslint/eslint@2620614) docs: Code of Conduct page ([#16781](eslint/eslint#16781)) (Ben Perlmutter) - [`50a8efd`](eslint/eslint@50a8efd) docs: report a sec vulnerability page ([#16808](eslint/eslint#16808)) (Ben Perlmutter) - [`ed60afd`](eslint/eslint@ed60afd) docs: Update page titles, section landing pages, and side TOC ([#16760](eslint/eslint#16760)) (Ben Perlmutter) - [`333c712`](eslint/eslint@333c712) docs: add background to code-path-diagrams for dark-mode ([#16822](eslint/eslint#16822)) (Tanuj Kanti) - [`f5f7b9b`](eslint/eslint@f5f7b9b) docs: Update README (GitHub Actions Bot) - [`2aa4f5f`](eslint/eslint@2aa4f5f) docs: no-constant-condition: Add multi-comparison example ([#16776](eslint/eslint#16776)) (Sebastian Simon) - [`40287db`](eslint/eslint@40287db) docs: Remove Google Group icon ([#16779](eslint/eslint#16779)) (Nicholas C. Zakas) - [`ea10ca5`](eslint/eslint@ea10ca5) docs: 'a .eslint' -> 'an .eslint' for consistency ([#16809](eslint/eslint#16809)) (Ben Perlmutter) - [`3be0748`](eslint/eslint@3be0748) docs: add example for nodejs lintText api ([#16789](eslint/eslint#16789)) (Siva K) - [`ce4f5ff`](eslint/eslint@ce4f5ff) docs: Replace removed related rules with a valid rule ([#16800](eslint/eslint#16800)) (Ville Saalo) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1759 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

docs: add background to code path diagrams

83f2f85

Tanujkanti4441 requested a review from a team as a code owner January 24, 2023 13:43

eslint-github-bot Bot added triage An ESLint team member will look at this issue soon documentation Relates to ESLint's documentation labels Jan 24, 2023

amareshsm added accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jan 24, 2023

amareshsm reviewed Jan 24, 2023

View reviewed changes

docs: aligns code-path-diagrams to center

7a8c0cb

snitin315 reviewed Jan 26, 2023

View reviewed changes

Tanujkanti4441 added 2 commits January 26, 2023 10:03

docs: add background to architecture image

fbf38be

fix: indentation checks

bdf4cf3

amareshsm approved these changes Jan 26, 2023

View reviewed changes

harish-sethuraman approved these changes Jan 26, 2023

View reviewed changes

snitin315 approved these changes Jan 26, 2023

View reviewed changes

snitin315 added the contributor pool label Jan 26, 2023

kecrily approved these changes Jan 26, 2023

View reviewed changes

mdjermanovic linked an issue Jan 26, 2023 that may be closed by this pull request

Docs: Non-readable diagrams when the dark theme is on #16683

Closed

1 task

mdjermanovic approved these changes Jan 26, 2023

View reviewed changes

mdjermanovic merged commit 333c712 into eslint:main Jan 26, 2023

github-actions Bot mentioned this pull request May 2, 2023

Upgraded some dependencies - Attempt 2 AurorNZ/report-updated-dependencies#638

Merged

eslint-github-bot Bot locked and limited conversation to collaborators Jul 26, 2023

eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jul 26, 2023

Tanujkanti4441 deleted the diagram-visibility branch July 27, 2023 11:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docs: add background to code-path-diagrams for dark-mode#16822

docs: add background to code-path-diagrams for dark-mode#16822
mdjermanovic merged 4 commits intoeslint:mainfrom
Tanujkanti4441:diagram-visibility

Tanujkanti4441 commented Jan 24, 2023

Uh oh!

netlify Bot commented Jan 24, 2023 •

edited

Loading

Uh oh!

amareshsm left a comment

Uh oh!

Tanujkanti4441 commented Jan 25, 2023 •

edited

Loading

Uh oh!

snitin315 left a comment

Uh oh!

Tanujkanti4441 commented Jan 26, 2023

Uh oh!

amareshsm left a comment

Uh oh!

harish-sethuraman left a comment

Uh oh!

snitin315 left a comment

Uh oh!

kecrily left a comment

Uh oh!

mdjermanovic left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Tanujkanti4441 commented Jan 24, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify Bot commented Jan 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint ready!

Uh oh!

amareshsm left a comment

Choose a reason for hiding this comment

Uh oh!

Tanujkanti4441 commented Jan 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snitin315 left a comment

Choose a reason for hiding this comment

Uh oh!

Tanujkanti4441 commented Jan 26, 2023

Uh oh!

amareshsm left a comment

Choose a reason for hiding this comment

Uh oh!

harish-sethuraman left a comment

Choose a reason for hiding this comment

Uh oh!

snitin315 left a comment

Choose a reason for hiding this comment

Uh oh!

kecrily left a comment

Choose a reason for hiding this comment

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

netlify Bot commented Jan 24, 2023 •

edited

Loading

Tanujkanti4441 commented Jan 25, 2023 •

edited

Loading