feat: add `allowEmptyCase` option to no-fallthrough rule by amareshsm · Pull Request #15887 · eslint/eslint

amareshsm · 2022-05-18T13:25:57Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[x] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Refs: #15703

What changes did you make? (Give an overview)

Change to the existing rule no-fallthrough.

Added an option to allow empty cases in the switch case.

Is there anything you'd like reviewers to focus on?

What rule do you want to change?

no-fallthrough

Does this change cause the rule to produce more or fewer warnings?
yes, if allowEmptyCase option is enabled will not show any error for empty cases.
How will the change be implemented? (New option, new default behavior, etc.)?
new option
Please provide some example code that this change will affect:

var foo = 2;
var a = function (){
    console.log('sample function');
}
switch(foo){
    case 1:
    /*
    Put a message here 
    */
    case 2: a();
}

What does the rule currently do for this code?

Throws error for the empty rule.
Error:

Expected a 'break' statement before 'case'. ([no-fallthrough](https://eslint.org/docs/rules/no-fallthrough))

What will the rule do after it's changed?

/* eslint no-fallthrough: ["error", { "allowEmptyCase": true }] */

If we set allowEmptyCase to true, won't show errors for empty cases regardless of blank lines and comments inside.

netlify · 2022-05-18T13:26:04Z

✅ Deploy Preview for docs-eslint ready!

Name	Link
🔨 Latest commit	`aa88f11`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/6303c8376a549c0009a3ad84
😎 Deploy Preview	https://deploy-preview-15887--docs-eslint.netlify.app/rules/no-fallthrough
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

mdjermanovic

Thanks for the PR!

Can you also update the documentation for this rule: docs/src/rules/no-fallthrough.md

amareshsm · 2022-05-18T17:58:36Z

Thanks for the PR!

Can you also update the documentation for this rule: docs/src/rules/no-fallthrough.md

updated the documentation.

mdjermanovic · 2022-06-28T17:54:55Z

@amareshsm are you still working on this? Please feel free to let us know if you need any help or more information. It would be nice to finish this, and I think it's close.

amareshsm · 2022-06-29T19:26:02Z

@amareshsm are you still working on this? Please feel free to let us know if you need any help or more information. It would be nice to finish this, and I think it's close.

Quite Held up this week. I will look into this soon. I will let you know if I need any help.

nzakas · 2022-07-27T00:46:38Z

@amareshsm just checking back to see if you are still working on this?

amareshsm · 2022-08-15T13:55:37Z

Changes done. PR is ready for review

mdjermanovic

LGTM, thanks!

I'll leave this open for a few days in case someone else wants to review it before merging.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.22.0` -> `8.23.0`](https://renovatebot.com/diffs/npm/eslint/8.22.0/8.23.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.23.0`](https://github.com/eslint/eslint/releases/tag/v8.23.0) [Compare Source](eslint/eslint@v8.22.0...v8.23.0) #### Features - [`3e5839e`](eslint/eslint@3e5839e) feat: Enable eslint.config.js lookup from CLI ([#16235](eslint/eslint#16235)) (Nicholas C. Zakas) - [`30b1a2d`](eslint/eslint@30b1a2d) feat: add `allowEmptyCase` option to no-fallthrough rule ([#15887](eslint/eslint#15887)) (Amaresh S M) - [`43f03aa`](eslint/eslint@43f03aa) feat: no-warning-comments support comments with decoration ([#16120](eslint/eslint#16120)) (Lachlan Hunt) #### Documentation - [`b1918da`](eslint/eslint@b1918da) docs: package.json conventions ([#16206](eslint/eslint#16206)) (Patrick McElhaney) - [`0e03c33`](eslint/eslint@0e03c33) docs: remove word immediately ([#16217](eslint/eslint#16217)) (Strek) - [`c6790db`](eslint/eslint@c6790db) docs: add anchor link for "migrating from jscs" ([#16207](eslint/eslint#16207)) (Percy Ma) - [`7137344`](eslint/eslint@7137344) docs: auto-generation edit link ([#16213](eslint/eslint#16213)) (Percy Ma) #### Chores - [`2e004ab`](eslint/eslint@2e004ab) chore: upgrade [@eslint/eslintrc](https://github.com/eslint/eslintrc)[@1](https://github.com/1).3.1 ([#16249](eslint/eslint#16249)) (Milos Djermanovic) - [`d35fbbe`](eslint/eslint@d35fbbe) chore: Upgrade to espree@9.4.0 ([#16243](eslint/eslint#16243)) (Milos Djermanovic) - [`ed26229`](eslint/eslint@ed26229) test: add no-extra-parens tests with rest properties ([#16236](eslint/eslint#16236)) (Milos Djermanovic) - [`deaf69f`](eslint/eslint@deaf69f) chore: fix off-by-one `min-width: 1023px` media queries ([#15974](eslint/eslint#15974)) (Milos Djermanovic) - [`63dec9f`](eslint/eslint@63dec9f) refactor: simplify `parseListConfig` ([#16241](eslint/eslint#16241)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).  Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1527 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

feat: allow empty case in switch

f480faf

eslint-github-bot Bot added triage An ESLint team member will look at this issue soon feature This change adds a new feature to ESLint labels May 18, 2022

mdjermanovic added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 18, 2022

mdjermanovic requested changes May 18, 2022

View reviewed changes

mdjermanovic reviewed May 18, 2022

View reviewed changes

Comment thread lib/rules/no-fallthrough.js Outdated

mdjermanovic linked an issue May 18, 2022 that may be closed by this pull request

Request: add option for no-fallthrough with newlines #15703

Closed

1 task

amareshsm added 2 commits May 18, 2022 22:47

feat: add test case with semicolon

194b263

docs:add allow emtpy case option in docs

a863465

amareshsm requested a review from mdjermanovic May 18, 2022 20:34

feat: disallow switch case with ;

86ca699

mdjermanovic reviewed Jun 6, 2022

View reviewed changes

Comment thread lib/rules/no-fallthrough.js Outdated

mdjermanovic requested changes Jun 14, 2022

View reviewed changes

Comment thread docs/src/rules/no-fallthrough.md Outdated

Comment thread docs/src/rules/no-fallthrough.md Outdated

Comment thread tests/lib/rules/no-fallthrough.js

amareshsm added 2 commits August 13, 2022 03:05

feat: disallow empty statement

2194529

Merge branch 'main' into add-allow-empty-case

de20ee9

amareshsm changed the title ~~feat: allow empty case in switch~~ feat: allow empty case in switch statement Aug 12, 2022

chore: lint .md file

56e4f70

amareshsm force-pushed the add-allow-empty-case branch from cbe7de3 to 56e4f70 Compare August 12, 2022 22:21

mdjermanovic changed the title ~~feat: allow empty case in switch statement~~ feat: add allowEmptyCase option to no-fallthrough rule Aug 17, 2022

mdjermanovic requested changes Aug 17, 2022

View reviewed changes

Comment thread docs/src/rules/no-fallthrough.md Outdated

Comment thread docs/src/rules/no-fallthrough.md

Comment thread docs/src/rules/no-fallthrough.md Outdated

Comment thread lib/rules/no-fallthrough.js Outdated

Comment thread lib/rules/no-fallthrough.js

remove redundant logic

aa88f11

amareshsm requested a review from mdjermanovic August 22, 2022 19:14

mdjermanovic approved these changes Aug 23, 2022

View reviewed changes

mdjermanovic merged commit 30b1a2d into eslint:main Aug 26, 2022

sync-by-unito Bot mentioned this pull request Sep 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.23.0 numbersprotocol/capture-cam#2013

Closed

moul-bot mentioned this pull request Sep 12, 2022

chore(deps-dev): bump eslint from 7.32.0 to 8.23.1 in /js berty/berty#4416

Closed

moul-bot mentioned this pull request Sep 26, 2022

chore(deps-dev): bump eslint from 7.32.0 to 8.24.0 in /js berty/berty#4439

Closed

eslint-github-bot Bot locked and limited conversation to collaborators Feb 23, 2023

eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 23, 2023

Uh oh!

Conversation

amareshsm commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

netlify Bot commented May 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for docs-eslint ready!

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

amareshsm commented May 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic commented Jun 28, 2022

Uh oh!

amareshsm commented Jun 29, 2022

Uh oh!

nzakas commented Jul 27, 2022

Uh oh!

amareshsm commented Aug 15, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

amareshsm commented May 18, 2022 •

edited

Loading

netlify Bot commented May 18, 2022 •

edited

Loading