feat: Catch more cases in no-constant-condition by captbaritone · Pull Request #15613 · eslint/eslint

captbaritone · 2022-02-16T06:29:16Z

Identify undefined and Boolean(somethingConstant) as both being constant.

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[X] Changes an existing rule (template)

What changes did you make? (Give an overview)

Expanded no-constant-condition to catch two types of additional cases:

if(undefined) {}

if(Boolean(1)) {}

Is there anything you'd like reviewers to focus on?

captbaritone · 2022-02-16T16:29:16Z

I've updated the commit message to mark this as a feat: in line with @mdjermanovic's change of the title of the PR.

Edit Strange, it looks like @eslintbot readded the bug tag which @mdjermanovic just removed...

mdjermanovic · 2022-02-16T16:34:05Z

Edit Strange, it looks like @eslintbot readded the bug tag which @mdjermanovic just removed...

I'm not sure why, both PR and commit tags are now feat:.

captbaritone · 2022-02-25T05:54:50Z

Updated.

captbaritone · 2022-03-03T06:28:38Z

cc @mdjermanovic for visibility (no hurry if you've already seen my update)

nzakas · 2022-03-09T01:36:54Z

@captbaritone are you still working on this?

captbaritone · 2022-03-09T01:52:31Z

Oh, thanks for pinging. I missed @mdjermanovic's last reply. Yes. Still working on this.

captbaritone · 2022-03-09T02:21:26Z

Updated.

captbaritone · 2022-03-09T02:31:08Z

I think the lint failure is failing on the main branch:

docs/user-guide/configuring/configuration-files.md: 361: MD009/no-trailing-spaces Trailing spaces [Expected: 0 or 2; Actual: 1]

mdjermanovic · 2022-03-09T11:50:12Z

I think the lint failure is failing on the main branch

It's fixed now, I'll close & reopen to re-run checks on top of the latest main.

mdjermanovic

Code LGTM!

Can you also update the documentation for this rule with a few examples?

Identify `undefined` and `Boolean(somethingConstant)` as both being constant.

captbaritone · 2022-03-10T04:53:24Z

I've fixed the docblock and added two examples to the docs.

mdjermanovic

LGTM, thanks for contributing!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.10.0` -> `8.11.0`](https://renovatebot.com/diffs/npm/eslint/8.10.0/8.11.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.11.0`](https://github.com/eslint/eslint/releases/v8.11.0) [Compare Source](eslint/eslint@v8.10.0...v8.11.0) #### Features - [`800bd25`](eslint/eslint@800bd25) feat: add `destructuredArrayIgnorePattern` option in `no-unused-vars` ([#15649](eslint/eslint#15649)) (Nitin Kumar) - [`8933fe7`](eslint/eslint@8933fe7) feat: Catch `undefined` and `Boolean()` in no-constant-condition ([#15613](eslint/eslint#15613)) (Jordan Eldredge) - [`f90fd9d`](eslint/eslint@f90fd9d) feat: Add ESLint favicon to the HTML report document ([#15671](eslint/eslint#15671)) (Mahdi Hosseinzadeh) - [`57b8a57`](eslint/eslint@57b8a57) feat: `valid-typeof` always ban `undefined` ([#15635](eslint/eslint#15635)) (Zzzen) #### Bug Fixes - [`6814922`](eslint/eslint@6814922) fix: escaping for square brackets in ignore patterns ([#15666](eslint/eslint#15666)) (Milos Djermanovic) - [`c178ce7`](eslint/eslint@c178ce7) fix: extend the autofix range in comma-dangle to ensure the last element ([#15669](eslint/eslint#15669)) (Milos Djermanovic) #### Documentation - [`c481cec`](eslint/eslint@c481cec) docs: add fast-eslint-8 to atom integrations (userguide) ([#15695](eslint/eslint#15695)) (db developer) - [`d2255db`](eslint/eslint@d2255db) docs: Add clarification about `eslint-enable` ([#15680](eslint/eslint#15680)) (dosisod) - [`8b9433c`](eslint/eslint@8b9433c) docs: add object pattern to first section of computed-property-spacing ([#15679](eslint/eslint#15679)) (Milos Djermanovic) - [`de800c3`](eslint/eslint@de800c3) docs: link to minimatch docs added. ([#15688](eslint/eslint#15688)) (Gaurav Tewari) - [`8f675b1`](eslint/eslint@8f675b1) docs: sort-imports add single named import example ([#15675](eslint/eslint#15675)) (Arye Eidelman) #### Chores - [`385c9ad`](eslint/eslint@385c9ad) chore: rm trailing space in docs ([#15689](eslint/eslint#15689)) (唯然) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1217 Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

…int#15613) Identify `undefined` and `Boolean(somethingConstant)` as both being constant.

…ion (eslint#15613)" This reverts commit d80a0bb.

eslint-github-bot Bot added triage An ESLint team member will look at this issue soon bug ESLint is working incorrectly labels Feb 16, 2022

captbaritone commented Feb 16, 2022

View reviewed changes

Comment thread lib/rules/no-constant-condition.js

captbaritone mentioned this pull request Feb 16, 2022

feat: Add rule no-constant-binary-expression #15296

Merged

1 task

mdjermanovic changed the title ~~fix: Catch more cases in no-constant-condition~~ feat: Catch more cases in no-constant-condition Feb 16, 2022

captbaritone force-pushed the more-is-constant-cases branch from 3023ae8 to eee9080 Compare February 16, 2022 16:28

eslint-github-bot Bot added the bug ESLint is working incorrectly label Feb 16, 2022

mdjermanovic removed the bug ESLint is working incorrectly label Feb 16, 2022

mdjermanovic reviewed Feb 16, 2022

View reviewed changes

Comment thread lib/rules/no-constant-condition.js Outdated

captbaritone force-pushed the more-is-constant-cases branch from eee9080 to b35bd7e Compare February 17, 2022 16:01

mdjermanovic reviewed Feb 18, 2022

View reviewed changes

Comment thread lib/rules/no-constant-condition.js Outdated

Comment thread lib/rules/no-constant-condition.js Outdated

captbaritone force-pushed the more-is-constant-cases branch from b35bd7e to 8f8d839 Compare February 25, 2022 05:51

mdjermanovic reviewed Mar 3, 2022

View reviewed changes

Comment thread lib/rules/no-constant-condition.js Outdated

captbaritone force-pushed the more-is-constant-cases branch from 8f8d839 to a73ccd8 Compare March 9, 2022 02:20

captbaritone force-pushed the more-is-constant-cases branch from a73ccd8 to fdfc92f Compare March 9, 2022 02:28

mdjermanovic closed this Mar 9, 2022

mdjermanovic reopened this Mar 9, 2022

mdjermanovic added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Mar 9, 2022

mdjermanovic requested changes Mar 9, 2022

View reviewed changes

Comment thread lib/rules/no-constant-condition.js

captbaritone force-pushed the more-is-constant-cases branch from fdfc92f to 0ef9dec Compare March 10, 2022 04:50

feat: Catch more cases in no-constant-condition

e9dd2ac

Identify `undefined` and `Boolean(somethingConstant)` as both being constant.

captbaritone force-pushed the more-is-constant-cases branch from 0ef9dec to e9dd2ac Compare March 10, 2022 04:53

mdjermanovic approved these changes Mar 10, 2022

View reviewed changes

mdjermanovic merged commit 8933fe7 into eslint:main Mar 10, 2022

sync-by-unito Bot mentioned this pull request Mar 30, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.12.0 numbersprotocol/capture-cam#1446

Closed

sync-by-unito Bot mentioned this pull request May 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.14.0 numbersprotocol/capture-cam#1569

Closed

srijan-deepsource pushed a commit to DeepSourceCorp/eslint that referenced this pull request May 30, 2022

feat: Catch undefined and Boolean() in no-constant-condition (esl…

d80a0bb

…int#15613) Identify `undefined` and `Boolean(somethingConstant)` as both being constant.

srijan-deepsource added a commit to DeepSourceCorp/eslint that referenced this pull request May 30, 2022

Revert "feat: Catch undefined and Boolean() in no-constant-condit…

613df5c

…ion (eslint#15613)" This reverts commit d80a0bb.

eslint-github-bot Bot locked and limited conversation to collaborators Sep 7, 2022

eslint-github-bot Bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Sep 7, 2022

Uh oh!

Conversation

captbaritone commented Feb 16, 2022

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Uh oh!

Uh oh!

captbaritone commented Feb 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mdjermanovic commented Feb 16, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

captbaritone commented Feb 25, 2022

Uh oh!

captbaritone commented Mar 3, 2022

Uh oh!

Uh oh!

nzakas commented Mar 9, 2022

Uh oh!

captbaritone commented Mar 9, 2022

Uh oh!

captbaritone commented Mar 9, 2022

Uh oh!

captbaritone commented Mar 9, 2022

Uh oh!

mdjermanovic commented Mar 9, 2022

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

captbaritone commented Mar 10, 2022

Uh oh!

mdjermanovic left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

captbaritone commented Feb 16, 2022 •

edited

Loading