Skip to content

[parser] Make decoratorsBeforeExport default to false#14695

Merged
nicolo-ribaudo merged 3 commits intobabel:feat-7.19.0/decoratorsfrom
nicolo-ribaudo:parser-default-decoratorsBeforeExport
Aug 16, 2022
Merged

[parser] Make decoratorsBeforeExport default to false#14695
nicolo-ribaudo merged 3 commits intobabel:feat-7.19.0/decoratorsfrom
nicolo-ribaudo:parser-default-decoratorsBeforeExport

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo commented Jun 26, 2022 •
edited
Loading

Q                       A
Minor: New Feature? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Ref #12712 (comment)

It already defaults to false in the transform plugin and in the generator.

@nicolo-ribaudo nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: parser Spec: Decorators labels Jun 26, 2022
@nicolo-ribaudo nicolo-ribaudo added this to the 7.19.0 milestone Jun 26, 2022
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Jun 26, 2022 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52719/

@nicolo-ribaudo nicolo-ribaudo added PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release ⚠️ Do not merge and removed ⚠️ Do not merge labels Jun 27, 2022
@nicolo-ribaudo nicolo-ribaudo force-pushed the parser-default-decoratorsBeforeExport branch from ffec2c6 to 942c580 Compare August 16, 2022 13:05
@nicolo-ribaudo nicolo-ribaudo changed the base branch from main to feat-7.19.0/decorators August 16, 2022 13:06
@nicolo-ribaudo nicolo-ribaudo merged commit db8cf71 into babel:feat-7.19.0/decorators Aug 16, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the parser-default-decoratorsBeforeExport branch August 16, 2022 13:08
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Aug 16, 2022
Merged
3 tasks
nicolo-ribaudo added a commit to nicolo-ribaudo/babel that referenced this pull request Aug 17, 2022
@nicolo-ribaudo
[parser] Make decoratorsBeforeExport default to false (babel#14695)
2974040
nicolo-ribaudo added a commit that referenced this pull request Aug 24, 2022
@nicolo-ribaudo
[parser] Make decoratorsBeforeExport default to false (#14695)
7c4227d
nicolo-ribaudo added a commit that referenced this pull request Aug 24, 2022
@nicolo-ribaudo
[parser] Make decoratorsBeforeExport default to false (#14695)
048d125
nicolo-ribaudo added a commit that referenced this pull request Sep 2, 2022
@nicolo-ribaudo
[parser] Make decoratorsBeforeExport default to false (#14695)
5b7a859
nicolo-ribaudo added a commit that referenced this pull request Sep 2, 2022
@nicolo-ribaudo
[parser] Make decoratorsBeforeExport default to false (#14695)
ea58127
nicolo-ribaudo added a commit that referenced this pull request Sep 5, 2022
@nicolo-ribaudo
[parser] Make decoratorsBeforeExport default to false (#14695)
d855f9d
@shaneomatz shaneomatz mentioned this pull request Nov 18, 2022
Open
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 18, 2022
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@JLHwung JLHwung JLHwung approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release Spec: Decorators

Projects

None yet

Milestone

7.19.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nicolo-ribaudo @babel-bot @JLHwung @sosukesuzuki