Fix derived classes in Chrome <= 36#14072
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Dec 30, 2021
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50451/ |
|
Fix works in chrome 14-36 (I can't test older versions) https://mrhenry.github.io/web-tests/#293ee801-4d53-4261-add3-dca6b9f8015f
No test cases dropped in score.
not going to do further runs at this time as it's a bit wasteful. edit : just read #14056 (comment) unsure if we need to wait with rolling this out until we receive more info on that? Update : I had to remove the patch from our test suite so posting latest results here :
|
JLHwung
approved these changes
Dec 23, 2021
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Nit: can you also add link to the upstream issue?
nicolo-ribaudo
commented
Dec 23, 2021
existentialism
approved these changes
Dec 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately we don't have the infrastructure to run tests in real old browsers, so you can either trust me and @romainmenke that it works or you can download Chrome <= 36 and try it yourself! 😅