Fix: default rest argument array elements as undefined#14032
Merged
nicolo-ribaudo merged 5 commits intobabel:mainfrom Dec 13, 2021
Merged
Fix: default rest argument array elements as undefined#14032nicolo-ribaudo merged 5 commits intobabel:mainfrom
nicolo-ribaudo merged 5 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50291/ |
JLHwung
approved these changes
Dec 10, 2021
Contributor
|
IMO this should not change any of the existing fixtures that don't name their rest element |
Actually, could you call path.scope.rename("arguments") if the rest binding is arguments, rather than updating the template? (#13992 (comment))
nicolo-ribaudo
approved these changes
Dec 11, 2021
JLHwung
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Default rest argument array elements won't be undefined anymore, It will give the correct output as required from the arguments with rest, Because now we first memoize the arguments and then bind the arguments to some other array.