Support flow function type annotation with no parent#14014
Merged
JLHwung merged 2 commits intobabel:mainfrom Dec 3, 2021
Merged
Support flow function type annotation with no parent#14014JLHwung merged 2 commits intobabel:mainfrom
JLHwung merged 2 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50100/ |
nicolo-ribaudo
approved these changes
Dec 1, 2021
JLHwung
reviewed
Dec 2, 2021
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
We should mark parent as t.Node | void so such errors can be caught by type checkers. Can you update the function typings?
nicolo-ribaudo
approved these changes
Dec 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a use case where I want to generate code for a FunctionTypeAnnotation node, and the node has no parent. When the node is passed into the FunctionTypeAnnotation handler, it assumes a parent exists.
I've added a check for the parent so that we don't try to read
.typeoff of an undefined parent.