Only bundle the release build, and don't import src in tests#13978
Merged
JLHwung merged 4 commits intobabel:mainfrom Nov 24, 2021
Merged
Only bundle the release build, and don't import src in tests#13978JLHwung merged 4 commits intobabel:mainfrom
src in tests#13978JLHwung merged 4 commits intobabel:mainfrom
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49913/ |
5e0d73c to
12c9476
Compare
lightmare
reviewed
Nov 20, 2021
12c9476 to
63f5f79
Compare
Member
Author
|
The last commit does #13966 (comment), with an extension that clearly indicates that those test files are skipped when publishing. |
existentialism
approved these changes
Nov 24, 2021
JLHwung
approved these changes
Nov 24, 2021
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from #13966.
With this PR, we:
make buildwithmake watchfor local development.librather thansrc. We must now skip these tests on the production build, but we were effectively already not testing the production bundle (because we were re-compilingsrcon the fly)