proposal-pipe: Add support for ^^ and @@ topics#13973
Merged
nicolo-ribaudo merged 4 commits intobabel:mainfrom Feb 2, 2022
Merged
proposal-pipe: Add support for ^^ and @@ topics#13973nicolo-ribaudo merged 4 commits intobabel:mainfrom
^^ and @@ topics#13973nicolo-ribaudo merged 4 commits intobabel:mainfrom
Conversation
3211175 to
00b43a0
Compare
^^ and @@ topics
JLHwung
reviewed
Nov 17, 2021
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Nov 19, 2021
This also allows expectPlugin and expectOnePlugin to give better error messages. For example:
> This experimental syntax requires enabling the parser plugin "pipelineOperator".
> This experimental syntax requires enabling the parser plugin ["pipelineOperator", {proposal: "hack", topicToken: "^^"}].
See babel#13973 (comment).
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Nov 20, 2021
This also allows expectPlugin and expectOnePlugin to give better error messages. For example:
> This experimental syntax requires enabling the parser plugin "pipelineOperator".
> This experimental syntax requires enabling the parser plugin ["pipelineOperator", {proposal: "hack", topicToken: "^^"}].
See babel#13973 (comment).
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Nov 26, 2021
This also allows expectPlugin and expectOnePlugin to give better error messages. For example:
> This experimental syntax requires enabling the parser plugin "pipelineOperator".
> This experimental syntax requires enabling the parser plugin ["pipelineOperator", {proposal: "hack", topicToken: "^^"}].
See babel#13973 (comment).
js-choi
added a commit
to js-choi/babel
that referenced
this pull request
Nov 29, 2021
This also allows expectPlugin and expectOnePlugin to give better error messages. For example:
> This experimental syntax requires enabling the parser plugin "pipelineOperator".
> This experimental syntax requires enabling the parser plugin ["pipelineOperator", {proposal: "hack", topicToken: "^^"}].
See babel#13973 (comment).
00b43a0 to
4fea500
Compare
Member
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Could you rebase this on top #13827? These two PRs conflict (because they both modify @ tokenizing), and we plan to merge both in the next minor 🙏
Member
|
Actually, don't rebase this on top of that branch yet because I want to first see what happens with tc39/proposal-decorators#437 at the next tc39 meeting. |
Contributor
Author
|
@nicolo-ribaudo: The plenary approved the decorator changes away from |
Member
|
It's not needed anymore, since without |
Contributor
Author
|
I’m working on resolving #13973 (comment). Do we need to add the new tokens to |
4fea500 to
c9584de
Compare
nicolo-ribaudo
previously approved these changes
Jan 8, 2022
Member
|
Yes, we need to add them to this list: |
c9584de to
91cb4b2
Compare
nicolo-ribaudo
approved these changes
Jan 26, 2022
JLHwung
approved these changes
Jan 30, 2022
Contributor
JLHwung
left a comment
There was a problem hiding this comment.
Look good to me with some paring nits.
e52460a to
8101e2b
Compare
8101e2b to
6668b73
Compare
Contributor
Author
|
Thanks for the work, everyone. I will try to work on deprecating the other topic tokens (except for |
This was referenced Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for experimental
^^and@@topic tokens for the pipe operator.I probably will make another pull request to deprecate all the other topicToken options after this gets merged, as per the recent November incubator meeting.
See also #13191, #13416, #13749. CC: @nicolo-ribaudo, @JLHwung, @tabatkins, @rbuckton, @mAAdhaTTah, @jridgewell, @sarahghp, @jamiebuilds.